search

awltech / easycukes

EasyCukes is just a framework aiming at making Cucumber even easier than what it already is.
GNU Lesser General Public License v3.0
4 stars 5 forks source link

Updated Step def #10

Closed GalandeVikram closed 8 years ago

GalandeVikram commented 8 years ago

Updated Step definition for Sonar scenarios to get 1st element from the json array and to check the response header has null value for testing negative test scenarios

aneveux commented 8 years ago

Hello @GalandeVikram,

Thanks a lot for that pullrequest :) It looks good but the CI is telling that it makes the build fail. Can you have a quick look at it please?

Thanks!

GalandeVikram commented 8 years ago

Thanks @aneveux Its existing issue in Junit test case, When I cloned the repository and build it on my local I faced same, hence I skipped the test and build the repository with updated step definitions.

It fails due to - Tests in error: testDownload(com.worldline.easycukes.commons.helpers.FileHelperTest): Connection timed out: connect

I am looking into this in detail to resolve

GalandeVikram commented 8 years ago

Hi @aneveux ,

I found that this is the proxy issue so that Test cases are getting failed.

I reproduced same on my local and resolved with following modification on my local (local proxy used) host: localhost port: 12345 enabled: true

and updated this testIsProxyNeeded() to true. and got success.

I found that we have jenkins job to build the github repository in Kazan in which we have skipped the test.

Regards, Vikram G.