Fix: Void tag followed by any non-whitespace character duplicates closing >

awmottaz / prettier-plugin-void-html

Use the void tag syntax

https://www.npmjs.com/package/@awmottaz/prettier-plugin-void-html

MIT License

54 stars 5 forks source link

Fix: Void tag followed by any non-whitespace character duplicates closing > #14

Closed f11xter closed 2 months ago

f11xter commented 8 months ago

Remove void element opening tag end marker (<br> → <br) if next element borrows it
Mark void element as isSelfClosing = true after printing to prevent parent from adding unwanted line breaks
When printing non-void element borrowing end marker from void element, mark void element as isSelfClosing = false to prevent adding /> to void element

Closes #10

f11xter commented 7 months ago

Polite nudge @awmottaz :)

awmottaz commented 7 months ago

Yes, sorry, thanks for being patient. Life happens 😅

I do want to look at this very soon! Haven't lost track of it

Kaleidosium commented 5 months ago

Any updates on this? This plugin will be very useful since Svelte removed self-closing tags due to it being incompatible with HTML. https://github.com/sveltejs/svelte/issues/11052

awmottaz commented 4 months ago

Apologies for being so slow here — it's still on my radar, just haven't found the time to verify @f11xter 's fix yet.

awmottaz commented 2 months ago

@f11xter omg thank you for waiting on this! I am finally finding some time to look more deeply at this PR. I have a couple questions, I'll drop comments on the diff.

In the meantime, I just released v1.6.0 of this plugin. Would you mind updating your branch to the latest from main?

awmottaz commented 2 months ago

Thanks again @f11xter — I'm ready to approve and merge this thing, looks like you just need to fix the linting issue (you can run npm run lint locally to check) and we're good to go!

f11xter commented 2 months ago

Thank you so much for looking at this and I'm glad to have helped :)