Fix deadlock when Panic is called during Purge

awnumar / memguard

Secure software enclave for storage of sensitive information in memory.

Apache License 2.0

2.49k stars 124 forks source link

Fix deadlock when Panic is called during Purge #156

Closed awnumar closed 5 months ago

awnumar commented 6 months ago

Fixes #147, fixes #155

Changes:

Stop initialising enclave key on process start; instead create new enclave keys when needed if there's no existing key
In coffer methods don't hold the enclave key when it's not needed, e.g. when creating a buffer
Don't auto-create a new key on Purge, instead wait until it's next needed
Update dependencies

srebhan commented 5 months ago

@awnumar we are planning a new release of Telegraf on December 11th and this PR is crucial for one of out PRs. Do you think you can merge this anytime soon? Anything I can do to help you out?

awnumar commented 5 months ago

@srebhan I've updated the PR with some changes. Please test and let me know if there's any problems, otherwise I'll merge.

srebhan commented 5 months ago

@awnumar I can confirm that the PR in its current state still works as expected and fixes #155. Thanks for all your effort!