awoken-bible / reference

NPM package for bible verse reference parsing, formating and meta data
MIT License
11 stars 3 forks source link

Extra Verses in ESV / CEV #5

Open jnterry opened 4 years ago

jnterry commented 4 years ago

This library uses the KJV versification scheme, compared to this:

Using this library to generate a list of verses therefore misses out these - which can cause errors if we iterate over two data sources (one generated based on verses from this library, and other based on verses actually present in a translation).

We should fix outstanding versification issues (such as https://github.com/awoken-bible/reference/issues/1) - then I think the default versification should be a "superset" which would generate all verses in all reasonable translations. This prevents this source of bugs where we miss out data.

We should export specifiic versification schemes for KJV / ESV / CEV as well.

This would (probably?) be a breaking change, so would require a major version bump.

jnterry commented 4 years ago

WEB also moves last 2 verses of romans 16 to last 2 verses of romans 14 - therefore increasing number of verses in romains 14. wikipedia


A "superset" versification scheme wouldn't help generic APIs which would need to remap the results for these moved veres (and actually for those listed in above post) - which potentially limits the usefulness of that idea (at least, for use as the default versification scheme).