search

awolden / brakes

Hystrix compliant Node.js Circuit Breaker Library
MIT License
300 stars 35 forks source link

Transpile src to lib #102

Closed DavideDaniel closed 6 years ago

DavideDaniel commented 6 years ago

It's possible the lib only needs to support down to node 6 but until the nvmrc is adjusted this transpile step will provide support for the documented node versions. Using babel-env set to node: current this also provides us the ability to just keep up with the node version changes seamlessly. Fixes #101

DavideDaniel commented 6 years ago

I'm thinking of declining this as the original issue is not really tied to transpilation but rather the inclusion of brakes into browser code inadvertently.. Unless you want the babel step to be able to continue further dev with new syntax this is unnecessary. Feel free to decline and close if it's not needed.

awolden commented 6 years ago

I agree that this should generally be kept out of client bundles. I will leave the PR open for awhile though to see if anyone else chimes in on a need for it.