awolden / brakes

Hystrix compliant Node.js Circuit Breaker Library
MIT License
300 stars 35 forks source link

#105 added a toggle to disabled prefixing error message with circuit … #106

Closed julekgwa closed 5 years ago

julekgwa commented 6 years ago

Added a toggle to disable prefixing upstream-service error messages. This happens when upstream respond with a non-string error message like { message: 'We are unable to process your request, please try again later', status: 400 }, Brakes then adds a prefix, the message becomes [Breaker: myservice] [object] [object] which is not helpful and can't be processed or used to display to the end-user.

julekgwa commented 5 years ago

Hi I have added a test case to test the toggle functionality.

juancoen commented 5 years ago

@julekgwa @awolden I find this really useful, will you merge it?

awolden commented 5 years ago

Fixed in #113