Added cumulative statistics to support request counter

awolden / brakes

Hystrix compliant Node.js Circuit Breaker Library

MIT License

300 stars 35 forks source link

Added cumulative statistics to support request counter #112

Closed Floix closed 5 years ago

Floix commented 5 years ago

As proposed in https://github.com/awolden/brakes/issues/55 I added cumulative counters that are independent of buckets. These counter stream out total requests (timeouts, etc.) per breaker, as well as the diff between two report events. The latter is necessary to support Prometheus counters effectively.

Counters are supported and named aligned with the Hystrix Metrics and Monitoring guide: https://github.com/Netflix/Hystrix/wiki/Metrics-and-Monitoring

awolden commented 5 years ago

This seems like a great addition 👍 Thanks for the PR. Can you increment the package.json version to 2.7.0 in this Pr?

Floix commented 5 years ago

I increased the version to 2.7.0

awolden commented 5 years ago

I will merge and publish, this weekend.