search

awolden / brakes

Hystrix compliant Node.js Circuit Breaker Library
MIT License
300 stars 35 forks source link

Add `exec` event #44

Closed SimenB closed 7 years ago

SimenB commented 7 years ago

We use prometheus to count this now, and to be able to migrate to this module, this event has to be present.

I suppose we'd get the same number from Hystrix, but still.

See #43 for fixed CI

awolden commented 7 years ago

Looks like a good to me. The build seems to be failing because it isn't installing a sub-dependency of mocha. I will take a look at that then get this PR and others merged in.

awolden commented 7 years ago

The testing fixes in your other PR have fixed the testing issue, but now there is a merge conflict that needs to be resolved before this can be merged.

SimenB commented 7 years ago

@awolden rebased 😄