search

awolden / brakes

Hystrix compliant Node.js Circuit Breaker Library
MIT License
300 stars 35 forks source link

Add Cumulative Counts to Hystrix Stream #55

Closed SimenB closed 5 years ago

SimenB commented 7 years ago

Currently a rolling count is kept, but not a cumulative one.

It would be great of both were available.

https://github.com/Netflix/Hystrix/wiki/Metrics-and-Monitoring#cumulative-and-rolling-event-counts

SimenB commented 7 years ago

@awolden ping :smile:

awolden commented 7 years ago

This would be a solid addition! Flagging as a feature request.

SimenB commented 7 years ago

Please say here if you work on it, I have it on my TODO list (which is admittedly pretty long ATM).

zanuka commented 7 years ago

@awolden any update on this one? keen to assist if no on else is

SimenB commented 7 years ago

I haven't gotten to it yet

Floix commented 5 years ago

@SimenB @awolden I worked on that and created a PR, would be great if you guys could review and merge it. I think it is an important enhancement for this lib.

PR: https://github.com/awolden/brakes/pull/112

awolden commented 5 years ago

Thanks for the contribution @Floix!