Closed SimenB closed 7 years ago
@SimenB This looks like a solid addition. I see no issue with releasing this as a minor version upgrade. I will merge and publish new version @ 2.4.0.
@awolden Hmm, it probably shouldn't reject at all. Looking at Levee's implementation:
I can update tomorrow
It would seem strange to have it not reject. If the isFailure()
function determines the error is not critical, it resolves the request? What would it return in the resolution?
Edit: Close and Comment
button is way too close to the comment
button. Reopened accidently closed PR.
It would resolve with null
I suppose
By providing isFailure
, and having it return false
you explicitly say it's not a failure, thus it shouldn't reject.
If a fallback is defined resolve with that, otherwise just resolve?
@awolden Thoughts on ^? I can update tomorrow if you agree
I think it makes sense as written. Levee still triggers the callback with the err
as the first argument, essentially rejecting it. I don't think this requires any additional changes.
Hmmm, true. Merge away, then!
This copies the idea (and description) from Levee.
https://github.com/krakenjs/levee#isfailure