search

awolden / brakes

Hystrix compliant Node.js Circuit Breaker Library
MIT License
300 stars 35 forks source link

Add isPromise #61

Closed SimenB closed 7 years ago

SimenB commented 7 years ago

Ref #39

/cc @sveisvei

sveisvei commented 7 years ago

Lgtm.

Might suggest we export a new PromiseBrakes() that defaults to isPromise:true but not sure it will just be confusing, up 2 you @awolden .

SimenB commented 7 years ago

@awolden ping :smile:

awolden commented 7 years ago

@sveisvei as these idiosyncrasies show up in the library it lends itself to rethinking how the API for brakes is designed, and it is good food for though regarding a possible version 3. For now, I think this change is satisfactory as is.