search

awolf78 / KISS_OSD

(micro) minimOSD firmware for the KISS FC. With all the latest shenanigans.
https://www.youtube.com/watch?v=XR2UEFcM3bA
The Unlicense
51 stars 16 forks source link

Add L-Band #31

Open andymac4182 opened 7 years ago

awolf78 commented 7 years ago

I assume you tested this? L-Band is illegal in most countries. I'm not sure if I want to support a totally illegal band even in my OS FW. Can you please wrap it in a #ifdef and add a #define L_BAND in Config.h? Then whoever wants to use it can just edit Config.h and compile. Also: Some code needs to be adapted in Menu.ino (and Menu_Config.ino for the config tool) for m_AussieChannels.

andymac4182 commented 7 years ago

I have tested this. Just confirming the exact RF frequencies are correct with an RF Explorer. Is this the line that needs fixing in Menu.ino https://github.com/awolf78/KISS_OSD/blob/master/KISS_OSD/Menu.ino#L1195-L1198 If so do I need to add a check for this band?

I will look at wrapping in a #ifdef.

awolf78 commented 7 years ago

You would most probably need a second if statement since the one you are referring to just skips E-band -L Band would be last, so you just have to prevent it from getting there. Make sure to wrap that in an #ifdef as well and also don't forget Menu_Config.ino in the KISS CONFIG TOOL.

EricJanVanDenBogaard commented 7 years ago

Yes, i guess you may not use the frequencies in the L band but you may have the option for it :) Just like there is a NFC "wand" special for competion officials to set vtx frequencies and power settings

awolf78 commented 7 years ago

That's why I suggested he wraps it with an #ifdef - then whoever wants it can recompile it with L-Band active.