awr / KafkaClient

Native C# client for Kafka
Apache License 2.0
5 stars 2 forks source link

migrate project to latest .NET Core structure (VS 2017) #27

Closed mantasaudickas closed 7 years ago

awr commented 7 years ago

Thanks for doing this!

Do you know if there's a way to have them run side by side? I don't currently have the RC on my machine (I've tried a couple times and it caused a number of issues locally). Also, all the ci stuff is based on the dotnet cli at the moment, so that'll have to be moved over before nuking the old approach.

mantasaudickas commented 7 years ago

On March 7th 2017 will be released as final, so makes sense to migrate already :) My local machine has VS2015 and VS2017 RC.. But I was not able to build xproj with 2015 (probably because of 2017 installed). In general you definitely can wait until you are ready before merging.

awr commented 7 years ago

Thanks for the issue -- it forced me to get the project onto the new visual studio. I've updated the various ci configs and so on separately, so I'm going to close this off now.