search

aws-actions / amazon-ecs-deploy-task-definition

Registers an Amazon ECS task definition and deploys it to an ECS service.
MIT License
630 stars 235 forks source link

Show deployment event logs to check if a deployment with ECS controller failed. #447

Open felipem1210 opened 1 year ago

felipem1210 commented 1 year ago

I tested what you had on the "Troubleshooting" section of the README and I thought that I was going to see the logs showed on ECS deployment events.

Maybe is not the intention, but the action is not being very useful on my use case. In my use case, the developers are constantly creating deployments and when it fails they are not all capable to see and determine the root cause of failure. I want to be able to output the latest events logs and give some guidance so the devs can troubleshoot on their own.

Also I want to create failure on the workflow run if the deployment didn't go well. that way they are also aware that revision needs to be made.

vgouv commented 1 month ago

I was about to search or create a solution for this. In our case things are worse, as for production deploymentis we have the circuit breaker enabled, along with rollback to previous state. Then it can happen that the github action ends with sucess code, while the deployment is rolled back (and successful). I think this will need a new PR apart from https://github.com/aws-actions/amazon-ecs-deploy-task-definition/pull/454, but it can provide a good starting point.