search

aws-actions / amazon-ecs-deploy-task-definition

Registers an Amazon ECS task definition and deploys it to an ECS service.
MIT License
643 stars 238 forks source link

Node 16 Deprecation Warning #535

Closed christian-ci closed 4 months ago

christian-ci commented 8 months ago

Describe the bug The GitHub Actions workflow is generating a deprecation warning due to the use of Node.js 16. GitHub Actions now requires the use of Node.js 20, as Node.js 16 actions have been deprecated.

To Reproduce Steps to reproduce the behavior:

  1. Go to the GitHub repository containing the workflow.
  2. Run the GitHub Actions workflow.
  3. Observe the deprecation warning in the workflow logs.
  4. The warning specifically mentions the use of Node.js 16 in aws-actions/amazon-ecs-deploy-task-definition@v1.

Expected behavior The expected behavior is for the GitHub Actions workflow to run without any deprecation warnings. It should use the updated Node.js 20 environment for all actions.

Screenshots

Screenshot 2024-01-25 at 15 51 43

Desktop (please complete the following information): OS Agnostic

Additional context The deprecation of Node.js 16 actions is part of GitHub's ongoing maintenance and update of their Actions infrastructure. More information about this transition can be found at: GitHub Blog Changelog.

TheMoonDawg commented 7 months ago

Any updates to this?

project0 commented 6 months ago

Looks like time is running out, did someone test existing action already with node20?

Following on from our warning in workflows using Node16 we will start enforcing the use of Node20 rather than Node16 on the 13th of May.

https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

msusta commented 6 months ago

Asked AWS support directly about status of this action. In the reply they mentioned that they are aware of the situation, however they are working to determine internal ownership - which to me sounds like there's no one working on this from AWS side. They don't have ETA on updates.

Sounds like a great time to start some community ECS actions.

christian-ci commented 6 months ago

@msusta Thanks a lot for asking them. I am in to start ECS actions community driven. I can only contribute in python though. Let me know.

jlauzze commented 6 months ago

I know it's not ideal, but the changes have been at least merged in. Our team is pinning to the commit sha for the time being, holding out hope they will go back to cutting releases with tags. A break the glass solution for sure as we approach May 13th. We did this for another action they aren't cutting releases for anymore as well.

Also, I can confirm by pinning that everything has worked as expected for us and no more warnings appear on our runs relating to this action.

uses: aws-actions/amazon-ecs-deploy-task-definition@302cdaeb9626318487c21c0fa156adc7bce7f32b

TheMoonDawg commented 5 months ago

@jlauzze Not reassuring you already had to do this workaround for a separate AWS action 🤣

tristanhill-iris commented 5 months ago

I've also had to pin the commit sha's for both this action and aws-actions/amazon-ecs-render-task-definition.

Not great that releases aren't being cut when the deadline is this close, but it's worth noting that pinning commit shas instead of major version tags is actually better practice (just a lot less convenient).

amazreech commented 4 months ago

Thank you for your patience. Node.js 20 upgrade was released with PR 537 as part of Release v1.5.0.