search

aws-actions / amazon-ecs-deploy-task-definition

Registers an Amazon ECS task definition and deploys it to an ECS service.
MIT License
643 stars 238 forks source link

chore: Upgrade to Node 20, remove deprecation warnings, upgrade CI deprecations #537

Closed singhprd closed 6 months ago

singhprd commented 7 months ago

Fix for https://github.com/aws-actions/amazon-ecs-deploy-task-definition/issues/535

The upgrading of the checkout action is a dup of this PR which hasn't had much attention given to it, this is a safe upgrade though so just pulling it in here anyway: https://github.com/aws-actions/amazon-ecs-deploy-task-definition/pull/471

This is currently affecting my workflows by adding lots of annotations, cluttering up the Actions experience. 😞 Screenshot 2024-02-07 at 12 44 35

It would be great if the maintainers here could upgrade the Node version to resolve this. This PR is a start on that, I'm not sure if I've missed anything. Tested it on our repo and it seems to work.

Thanks

singhprd commented 7 months ago

@efekarakus / @dannyrandall / AWS maintainers (📯) , it would be great if you had any time to have a look at getting these deprecations looked at, cheers!

TheMoonDawg commented 6 months ago

Any updates to this?

almiavicas commented 6 months ago

2 months to go for the Github enforcement of Node 20 usage! https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

I'm not sure how this will impact users, but it would be really nice for the community to have this upgrade done before that date. This is a great Github Action and I would love to keep using it. Let me know if I can help in any way to get this merged!

ZsoltPath commented 6 months ago

@KollaAdithya thanks for approving and merging this! Can we get a release now?

cabello commented 6 months ago

Hi there, I see this has been merged but I don't see a release yet, should we just point to master or wait for a release?

jedipunkz commented 5 months ago

@KollaAdithya Please release tag. GitHub plans to transition to run on Node 20 by Spring 2024.

https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

Our plan is to transition all actions to run on Node 20 by Spring 2024. We will actively monitor the migration's progress and gather community feedback before finalizing the transition date.

wilkinson4 commented 5 months ago

Starting to wonder if this action is still maintained.

patrick-scully-ef commented 5 months ago

Starting to wonder if this action is still maintained.

I pinned the commit SHA instead of the version