aws-actions / amazon-ecs-deploy-task-definition

Registers an Amazon ECS task definition and deploys it to an ECS service.
MIT License
651 stars 239 forks source link

feat: Tags for services and ad-hoc run #629

Closed guikcd closed 2 months ago

guikcd commented 2 months ago

Issue #, if available: Closes: #605, closes: #538

Description of changes:

Add support for tags:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

guikcd commented 2 months ago

I encountered an issue when wanted to propagate tags from task definition for run-task because of https://github.com/aws-actions/amazon-ecs-deploy-task-definition/issues/249#issuecomment-1538851215. The describe-task-definition can return tags, but it need to be merged to the task definition, which is not easy to do with cli or in amazon-ecs-render-task-definition (see https://github.com/aws-actions/amazon-ecs-render-task-definition/issues/317).

guikcd commented 2 months ago

@kg-aws ready to review