aws-actions / amazon-ecs-render-task-definition

Inserts a container image URI into an Amazon ECS task definition JSON file.
MIT License
261 stars 138 forks source link

Action does not respect github default working directory #120

Open Mistobaan opened 2 years ago

Mistobaan commented 2 years ago

Action does not respect github default working directory

image

Previous issues that had to deal with this subtle error: https://github.com/aws-actions/amazon-ecs-render-task-definition/issues/68#issuecomment-881407765

paragbhingre commented 2 years ago

@Mistobaan Thank you for raising this issue with us, we will get back to you once we have answer to this issue.

pdehlke commented 2 years ago

Any word on this?

dibyadhar commented 1 year ago

Any update on this ?

michaeloyer commented 7 months ago

Ran into this issue today as well and unfortunately it does not appear this will be something that gets changed.

Right now you either give it an absolute path OR it puts it in the directory attached to the GITHUB_WORKSPACE environment variable.

In case workarounds will help someone in the future you can either:

  1. Write to the environment variable which is at the root of your checked out files (what I'm doing):
- name: Download task definition
  run: |
    aws ecs describe-task-definition --task-definition ${{ env.ECS_TASK_DEFINITION }} --query taskDefinition \
      > ${{ github.workspace }}/task-definition.json

- name: Fill in the new image ID in the Amazon ECS task definition
  id: task-def
  uses: aws-actions/amazon-ecs-render-task-definition@v1
  with:
    task-definition: task-definition.json
    container-name: ...
    image: ...
  1. Write to the temp directory /tmp/task-definition.json (YMMV with what OS you are using)
- name: Download task definition
  run: |
    aws ecs describe-task-definition --task-definition ${{ env.ECS_TASK_DEFINITION }} --query taskDefinition \
      > /tmp/task-definition.json

- name: Fill in the new image ID in the Amazon ECS task definition
  id: task-def
  uses: aws-actions/amazon-ecs-render-task-definition@v1
  with:
    task-definition: /tmp/task-definition.json
    container-name: ...
    image: ...