search

aws-actions / amazon-ecs-render-task-definition

Inserts a container image URI into an Amazon ECS task definition JSON file.
MIT License
274 stars 142 forks source link

feat: support for setting environment secrets, and other task-def params #204

Open pierre-wehbe opened 1 year ago

pierre-wehbe commented 1 year ago

Description of changes: These commits add a few extra inputs (all optional)

I've updated the tests to include testing for all these.

joshuabalduff commented 1 year ago

@clareliguori @hyandell @kdaily @awood45 @mattsb42-aws Can anyone take a look at this or know who can?

jameshopkins commented 1 year ago

Is there any progress in getting this released?

OzzieOrca commented 1 year ago

Any updates here? Having secrets, executionRoleArn, and taskRoleArn would be really nice to not have to maintain a separate .json file for each environment.

sh-mykola commented 1 year ago

Can this be merged any time soon?

OzzieOrca commented 1 year ago

@sh-mykola see https://github.com/aws-actions/amazon-ecs-render-task-definition/issues/252#issuecomment-1687259661 for another option using https://github.com/marketplace/actions/update-json-file to manually edit a JSON file (outside any AWS context), since that's all that really needs to be done.

sh-mykola commented 1 year ago

Thank you! But I still think providing SSM name as variable is much smoother experience

joshuabalduff commented 6 months ago

Is this something that can merged in now? I haven't looked to see the conflicts.

amazreech commented 5 months ago

Hi @pierre-wehbe, thank you so much for your contribution. Apologies on the delay. We will be working on reviewing Pull Requests on the repository. In the mean time please ensure that below steps, if not already done, are taken care of in your PR:

  1. Verify if PR follows semantic pull request conventions.

  2. Please run npm run package command to update dist/ folder with latest dependencies.

  3. Resolve merge conflicts on the PR if any.