search

aws-actions / amazon-ecs-render-task-definition

Inserts a container image URI into an Amazon ECS task definition JSON file.
MIT License
274 stars 142 forks source link

feat: add possibility to add more than one container in container-name #229

Open felipem1210 opened 1 year ago

felipem1210 commented 1 year ago

Issue #, if available: https://github.com/aws-actions/amazon-ecs-render-task-definition/issues/228

Description of changes:

In this PR I'm adding the possibilty to pass more than one container inside container-name input. The container names can be passed comma separated. The same image and environment variables will be applied to all the containers

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

DragosDumitrache commented 7 months ago

Just want to say, can't wait for this feature to be merged in, it's going to be particularly helpful!

amazreech commented 5 months ago

Hi @felipem1210, thank you so much for your contribution. Apologies on the delay. We will be working on reviewing Pull Requests on the repositories. In the mean time please ensure that below steps, if not already done, are taken care of in your PR:

  1. Verify if PR follows semantic pull request conventions.

  2. Please run npm run package command to update dist/ folder with latest dependencies.

  3. Resolve merge conflicts on the PR if any.

felipem1210 commented 5 days ago

@amazreech I was totally unaware that you had reviewed this PR, I just have resolved the conflicts, glad to know that there is people still maintaining this project