search

aws-actions / amazon-ecs-render-task-definition

Inserts a container image URI into an Amazon ECS task definition JSON file.
MIT License
261 stars 142 forks source link

feat: adds env-files input to the github action #235

Closed bmbferreira closed 2 months ago

bmbferreira commented 1 year ago

Description of changes:

Adds the env-files input to the github action to be possible to pass env files into the task definition as described here: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/taskdef-envfiles.html

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

bmbferreira commented 10 months ago

@iamhopaul123 sorry to ping you, but I have this PR open for a long time... Is this action still maintained by AWS or should I keep using my fork with this fix? Thanks

bmbferreira commented 3 months ago

@iamhopaul123 I just fixed the conflicts on this PR. Also noticed you merged https://github.com/aws-actions/amazon-ecs-render-task-definition/pull/284 3 days ago. Is thera anything missing on this PR? Would love to see it merged, since I've been using my fork for more than 1 year now because I really need to set the environmentFiles on the task. Thanks in advance.

RDhar commented 2 months ago

Would be great to have this as it greatly improves upon how easily env vars can be populated in bulk within CICD workflows.

bmbferreira commented 2 months ago

nice, now I have conflicts again... @iamhopaul123 @clareliguori @Lou1415926 anyone from AWS please answer... this github action is used by 26.9k users according to github stats and seems there's multiple users interested in having the env-files as input on the github action. What's blocking this PR to be merged? I can fix the conflicts again, but can you guarantee that this will be merged afterwards? Otherwise I'll just be wasting my time again 🤷‍♂️ Thank you.

amazreech commented 2 months ago

Hi @bmbferreira !

Thank a lot of for your contribution. Apologies for the delayed response. We will be working on this issue. Would be great if you could do following steps for now:

  1. Update the PR title to conventional commits to feat: adds env-files input to the github action
  2. Fix the conflicts
bmbferreira commented 2 months ago

@amazreech thanks for replying! 🙇 just changed the PR title and fixed the conflicts. Please let me know if you need anything else to get this approved and merged. Thank you!

RDhar commented 2 months ago

Fantastic to see momentum pick up around this GH Action again, releasing small yet very meaningful updates -- no less, contributed by members of the community!