search

aws-actions / amazon-ecs-render-task-definition

Inserts a container image URI into an Amazon ECS task definition JSON file.
MIT License
261 stars 142 forks source link

feat: ability to configure log driver and log options #255

Closed sombriks closed 10 months ago

sombriks commented 1 year ago

Issue #254

Description of changes:

For my workflow i need to override the awslogs-group value so it doesn't clash with other group names. app on dev environment and app on staging would override messages if the task definition file is shared between them, and turns out it is.

By having a chance to override log configuration i can rename the property without having to keep different versions of the same task definiton.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

KollaAdithya commented 12 months ago

Looks like i do not have any write access to merge the PR. I will contact the right person to merge this PR.

tetienne-zenchef commented 10 months ago

Hi, it would be nice to create a release that contains this feature. Thx.

jonathanhuang13 commented 8 months ago

Yeah, can we create a release? Looks like a release hasn't been created since January