search

aws-actions / amazon-ecs-render-task-definition

Inserts a container image URI into an Amazon ECS task definition JSON file.
MIT License
261 stars 138 forks source link

closes #135 #265

Closed PaddeK closed 1 month ago

PaddeK commented 9 months ago

Issue #, if available: #135

Description of changes: Adds support for task definition tags

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

amazreech commented 2 months ago

Hi @PaddeK, thank you so much for your contribution. We will be working on reviewing Pull Requests on the repositories. In the mean time please ensure that below steps, if not already done, are taken care of in your PR:

  1. Verify if PR follows semantic pull request conventions. Example: Update PR title to follow conventions starting with "feat: ..."

  2. Please run npm run package command to update dist/ folder with latest dependencies.

  3. Resolve merge conflicts on the PR, if any

ulisseshen commented 1 month ago

any news?