search

aws-actions / amazon-ecs-render-task-definition

Inserts a container image URI into an Amazon ECS task definition JSON file.
MIT License
261 stars 138 forks source link

feat: support dockerLabels #274

Closed johnseekins-pathccm closed 8 months ago

johnseekins-pathccm commented 9 months ago

Issue #, if available: #272

Description of changes:

Add support for dockerLabels in task rendering. Basically updating #138

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

johnseekins-pathccm commented 9 months ago

@sapekshm @iamhopaul123 I see you've recently worked on PRs in this repo. Any chance we could get this change merged? And maybe even a new release cut with this change?

iamhopaul123 commented 9 months ago

Hello @johnseekins-pathccm the PR looks good to me. Can you fix failed checks before merging?

johnseekins-pathccm commented 9 months ago

I can't run workflows, but tests are passing locally now. @iamhopaul123 , I think this is ready?

iamhopaul123 commented 9 months ago

hello @johnseekins-pathccm looks like the tests are green now. Can you follow the https://conventionalcomments.org/ and fix the title and commit?

KollaAdithya commented 8 months ago

@johnseekins-pathccm ! Can you change your title to feat: support dockerLabels

johnseekins-pathccm commented 8 months ago

It's pretty clear that whatever I did didn't follow semantic commits and I don't entirely understand how to fix it. Y'all are welcome to just take the code in a new PR, or if someone wants to tell me exactly how to format the PR to make this work, I'd love some advice.

tristanhill-iris commented 8 months ago

It's pretty clear that whatever I did didn't follow semantic commits and I don't entirely understand how to fix it. Y'all are welcome to just take the code in a new PR, or if someone wants to tell me exactly how to format the PR to make this work, I'd love some advice.

@johnseekins-pathccm I don't think rerunning the workflow actually refreshes the values passed into it via the context.payload.pull_request (https://github.com/aws-actions/amazon-ecs-render-task-definition/actions/runs/6509556132/job/17971730910?pr=274#step:2:5), so it's still validating against the old PR title. You could try pushing a new commit (or amend the last one) with no changes to re-trigger the check?