search

aws-actions / amazon-ecs-render-task-definition

Inserts a container image URI into an Amazon ECS task definition JSON file.
MIT License
261 stars 138 forks source link

dockers-labels not working #277

Closed ShreyAmbesh closed 7 months ago

ShreyAmbesh commented 8 months ago

I was waiting for the PR #274 to be merged but it doesn't look like it's working. "docker-labels" is not appearing as a valid input.

image

The documentation on the marketplace also differs for the action on default page and version selected page On the default landing page the Readme has the docker-labels in the examples whereas when version is selected as version 1 which is the only available version the page doesn't has docker-labels example. Ideally both should be same as version 1 is the latest and the only version.

ShreyAmbesh commented 8 months ago

@johnseekins-pathccm Can you please help me with this?

johnseekins-pathccm commented 8 months ago

They haven't cut a new release. It's working for me if I use 

      uses: aws-actions/amazon-ecs-render-task-definition@master
ShreyAmbesh commented 8 months ago

@johnseekins-pathccm Thanks for the help.

johnseekins-pathccm commented 8 months ago

If that solves your problem, I'd encourage you to close the issue.