search

aws-actions / amazon-ecs-render-task-definition

Inserts a container image URI into an Amazon ECS task definition JSON file.
MIT License
261 stars 138 forks source link

Node16 deprecation warning #285

Closed christian-ci closed 2 months ago

christian-ci commented 5 months ago

Describe the bug The GitHub Actions workflow is generating a deprecation warning due to the use of Node.js 16. GitHub Actions now requires the use of Node.js 20, as Node.js 16 actions have been deprecated.

To Reproduce Steps to reproduce the behavior:

  1. Go to the GitHub repository containing the workflow.
  2. Run the GitHub Actions workflow.
  3. Observe the deprecation warning in the workflow logs.
  4. The warning specifically mentions the use of Node.js 16 in aws-actions/amazon-ecs-render-task-definition@v1.

Expected behavior The expected behavior is for the GitHub Actions workflow to run without any deprecation warnings. It should use the updated Node.js 20 environment for all actions.

Screenshots

Screenshot 2024-01-25 at 15 58 40

Desktop (please complete the following information): OS Agnostic

Additional context The deprecation of Node.js 16 actions is part of GitHub's ongoing maintenance and update of their Actions infrastructure. More information about this transition can be found at: GitHub Blog Changelog.

DanielLaberge commented 4 months ago

I too would like to have GitHub logs free of warnings.

martingleria commented 4 months ago

https://github.com/aws-actions/amazon-ecs-render-task-definition/pull/287

How can we have this PR merged?

jeropaul commented 3 months ago

Is this action still supported by AWS or do I (we) need to start looking at alternatives?

christian-ci commented 3 months ago

Not really sure. Why not like tag whoever worked on the last PRs that were merged.

jeropaul commented 3 months ago

Progress! #287 has been merged so now we just need a new release...

jlauzze commented 3 months ago

@iamhopaul123 is there any way you could cut a new release? Thanks!

nireld commented 3 months ago

@iamhopaul123 Ping, please create a new release bro, Thanks!

AlbertCintas commented 3 months ago

Asking for a new release too. Please and thank you!

aiell0 commented 3 months ago

Another ask for a new release please, I don't like warnings.

baraknaveh commented 3 months ago

Is anyone still maintaining this?

ghosttown

jensenbox commented 2 months ago

Anyone know anyone @aws that can put some heat under this?

jlauzze commented 2 months ago

Not ideal, but until a release is cut, we can pin to the commit sha that includes the node20 fixes. Our team has done it for the time being, no more run warnings, and everything has been working fine. Just a suggestion, it may not be an adequate solution for all.

uses: aws-actions/amazon-ecs-render-task-definition@35d224b2ca3f343a8b46e0362c097786a88513bb

baraknaveh commented 2 months ago

Thanks @jlauzze for this -- good idea!

AlbertCintas-insurteam commented 2 months ago

Thank you @jlauzze! Good idea!

amazreech commented 2 months ago

Thank you for your patience. Node.js 20 upgrade was released with PR 287 as part of Release v1.3.0.

nireld commented 2 months ago

FINALLY!