search

aws-actions / amazon-ecs-render-task-definition

Inserts a container image URI into an Amazon ECS task definition JSON file.
MIT License
261 stars 138 forks source link

feat: Add support for task and execution role ARNs in action.yml and … #293

Open DMEvanCT opened 2 months ago

DMEvanCT commented 2 months ago

…index.js

Issue #, if available:

Description of changes: Adding the ability to do set task role arn and the execution role arn. This may be different from account to account so setting it would provide a little flexibility.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

amazreech commented 2 months ago

Hi @DMEvanCT, thank you so much for your contribution. Apologies on the delay. We will be working on reviewing Pull Requests on the repositories. In the mean time please ensure that below steps, if not already done, are taken care of in your PR:

  1. Verify if PR follows semantic pull request conventions.

  2. Please run npm run package command to update dist/ folder with latest dependencies.

  3. Resolve merge conflicts on the PR