Closed chefren closed 11 months ago
@kddejong @MeroFuruya please review when possible.
I think its worth adding in the code snippet from here to this pr and including a changeSetName
parameter to deployStack
instead of an or condition.
deploy.ts
export async function deployStack(
cfn: aws.CloudFormation,
params: CreateStackInput,
changeSetName: string,
noEmptyChangeSet: boolean,
...
return await updateStack(
cfn,
stack,
{
ChangeSetName: changeSetName,
...{
StackName: params.StackName,
...
@ kddejong @MeroFuruya please review when possible.
@chefren i mean i obviously did some really nasty stuff there, sorry for that ._.
but i guess you should at least make all the tests run green 👀
and sorry for the late reply, didnt see the notification
Whats the goal on this one? I agree with the changes that @josealdaco has done. Let me know if you can get that done and I'll get it merged and released
Issue #112
Description of changes:
Made ChangesetName optional.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.