search

aws-actions / aws-cloudformation-github-deploy

Deploys AWS CloudFormation Stacks
MIT License
251 stars 121 forks source link

Adding ability to have comma delimited values within quotes for parameter-verrides. #48

Closed timharris777 closed 3 years ago

timharris777 commented 3 years ago

Issue #, if available:

47

Description of changes: Updated src/utils.ts so that it properly accepts comma separated values within quotes for parameter-overrides. An example would be to pass in a list of subnets.

I confirmed all tests are passing and that the code works.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

timharris777 commented 3 years ago

@katallaxie, can someone take a look at this pull request? We would like to stop use your official version as opposed to maintaining our forked version.

Sunilsbcloud commented 3 years ago

@katallaxie, or anyone please look into this PR, this looks to be an important feature and affecting many scenarios.

timharris777 commented 3 years ago

Quick update, I spoke to our AWS rep and they are trying to identify a new owner for this repo.

rvdbogerd commented 3 years ago

We have the same issue, the fix is looking good. let's merge it, shall we?

monemihir commented 1 year ago

Noooo why was this closed, I really need this to be merged in :(

paulvav commented 1 year ago

Bump - also need this please!

kddejong commented 1 year ago

I will pick this up this week and see if we can get it out there.

kddejong commented 1 year ago

Worth noting that you can do this as follows: MyParam1=myValue1,MyParam2=myValue2,MyParam2=myValue3

https://github.com/aws-actions/aws-cloudformation-github-deploy/blob/87a972c53e8e3eba056d472b9579c2cd584be99a/__tests__/utils.test.ts#L59-L73

We could look at changing this but does this fix the issue you are having?