aws-actions / aws-codebuild-run-build

Run an AWS CodeBuild project as a step in a GitHub Actions workflow job.
https://aws.amazon.com/codebuild
Apache License 2.0
275 stars 140 forks source link

Update to node16 and bump actions core #115

Closed snowiow closed 1 year ago

snowiow commented 1 year ago

Hi I'm recreating the PR from here to get rid of the deprecations that are currently shown in GitHub Actions. This should be released until the 31 of May, otherwise every workflow using this action will stop working. See here for the announcement of GitHub.

Issue #, if available: https://github.com/aws-actions/aws-codebuild-run-build/issues/109

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

patrick-scully-ef commented 1 year ago

+1 vote to merge this PR and create a new release. TY!

taoyong-ty commented 1 year ago

I've released this change in a new version -- v1.0.7

Thanks again!

snowiow commented 1 year ago

@taoyong-ty the distributable index.js doesn't seem to be up to date with what should be the current state. In dist/index.js the setOutput function still looks like this:

function setOutput(name, value) {
    command_1.issueCommand("set-output", { name }, value);
}

but the function in @actions/core version 1.10.0 now looks like this:

function setOutput(name, value) {
    const filePath = process.env['GITHUB_OUTPUT'] || '';
    if (filePath) {
        return file_command_1.issueFileCommand('OUTPUT', file_command_1.prepareKeyValueMessage(name, value));
    }
    process.stdout.write(os.EOL);
    command_1.issueCommand('set-output', { name }, utils_1.toCommandValue(value));
}

This causes the warning to still appear. Is there something wrong in the release process? Because the file was at least updated, but not with what is expected.

snowiow commented 1 year ago

Ok those were only some formattings from my commit and there is no actual release action. I provided the updated dist/index.js in this PR