aws-amplify / amplify-android

The fastest and easiest way to use AWS from your Android app.
https://docs.amplify.aws/lib/q/platform/android/
Apache License 2.0
249 stars 117 forks source link

Push notification body gets truncated #2857

Closed jamilsaadeh97 closed 4 months ago

jamilsaadeh97 commented 5 months ago

Before opening, please confirm:

Language and Async Model

Not applicable

Amplify Categories

Notifications

Gradle script dependencies

Not applicable

Environment information

Not applicable

Please include any relevant guides or documentation you're referencing

No response

Describe the bug

Notifications are being truncated when the body exceeds ~90 characters. The reason is that "long" notifications are not being handled here by using the BigTextStyle.

I'm using Amplify Flutter and I can't override these properties in my app.

I've opened #2856 to fix this

Thank you!

Reproduction steps (if applicable)

  1. Put app in the background
  2. Send a notification with body: "This is a long push notifications message that's supposed to be completely shown on the user device"

Code Snippet

// Put your code below this line.

Log output

``` // Put your logs below this line ```

amplifyconfiguration.json

No response

GraphQL Schema

```graphql // Put your schema below this line ```

Additional information and screenshots

No response

vincetran commented 5 months ago

Hi @jamilsaadeh97 Thanks for the report and the PR! I'll try to get to looking at your PR before the end of the week.

jamilsaadeh97 commented 5 months ago

Hi @vincetran looking forward for your feedback!

github-actions[bot] commented 4 months ago

This issue is now closed. Comments on closed issues are hard for our team to see. If you need more assistance, please open a new issue that references this one.

mattcreaser commented 4 months ago

Did not mean to auto-close this. We typically only close issues once the fix is released. This PR has been merged and will be included in our next release.

mattcreaser commented 4 months ago

This fix we released in Amplify 2.20.0 😄

github-actions[bot] commented 4 months ago

This issue is now closed. Comments on closed issues are hard for our team to see. If you need more assistance, please open a new issue that references this one.