Closed tKaneko129 closed 3 months ago
Hi @tKaneko129, this change looks good to me, but for clarity could you share the stacktrace for the exception you're seeing?
Hi @mattcreaser , Thank you for your confirmation. Attached is a stack trace of the exceptions we are checking.
Thank you! I don't see any issues with the change.
I've started running the tests for this PR. Once we have some passing runs we will get this merged for our next release.
Hi @mattcreaser , @tylerjroach , Sorry for the late reply. Thank you for your quick response. Looking forward to our continued collaboration. Kind regards,
Issue #, if available: None
Description of changes: Fix to catch exception when icon image download fails from notification payload. If an exception is thrown, the image data is treated as null.
How did you test these changes? This has not been checked as there is no back-end available. The following commands were executed, but originally failed.
./gradlew clean build
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.