aws-amplify / amplify-android

The fastest and easiest way to use AWS from your Android app.
https://docs.amplify.aws/lib/q/platform/android/
Apache License 2.0
249 stars 117 forks source link

feat(apollo): Use HTTP headers instead of query parameters for authorization #2916

Closed mattcreaser closed 1 month ago

mattcreaser commented 2 months ago

Issue #, if available:

Description of changes: AppSync recently added the ability to use HTTP headers instead of query parameters to authorize the websocket connection request. This is now the recommended way to connect (and new AppSync instances will eventually stop accepting query parameters).

This change switches the apollo-appsync library to use this new method of authorization.

How did you test these changes?

Documentation update required?

General Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.01%. Comparing base (7f874ed) to head (bfb3cf9). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2916 +/- ## ========================================== - Coverage 44.01% 44.01% -0.01% ========================================== Files 926 931 +5 Lines 30485 30688 +203 Branches 4351 4496 +145 ========================================== + Hits 13419 13507 +88 - Misses 15601 15697 +96 - Partials 1465 1484 +19 ```