aws-amplify / amplify-android

The fastest and easiest way to use AWS from your Android app.
https://docs.amplify.aws/lib/q/platform/android/
Apache License 2.0
249 stars 117 forks source link

fix(logging): CloudWatch Plugin 16KB page size support #2919

Open tylerjroach opened 2 months ago

tylerjroach commented 2 months ago

Issue #, if available:

Description of changes:

How did you test these changes? (Please add a line here how the changes were tested)

Documentation update required?

General Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

tylerjroach commented 2 months ago

Need to test a few scenarios given that this isn't just a version bump, but a new library for SqlCipher.

  1. Test on new install (creation of new db)
  2. Test on old install (db still readable)
vincetran commented 12 hours ago

Testing scenario:

Validated:

  1. Tested a brand new install with the NEW SQLCipher dependency can insert events into the database
  2. Pulled the database locally, decrypted it, and validated the contents were correct
  3. Then tested that going BACK to using the OLDER SQLCipher works without issue
  4. Inserting NEW events into the database worked
  5. Pulled the updated database locally, decrypted it, and validated the new AND old events were there
  6. Cleared app data, validated database was deleted.
  7. Relaunched app, inserted a few events, verified a new passphrase was created
  8. Pulled the database locally, decrypted it, and validated the contents were correct
  9. Updated the SQLCipher dependency back to the NEW version
  10. Relaunched app, inserted a few new events, verified the passphrase was the same as in step 7
  11. Pulled the database locally, decrypted it, and validated the contents were correct and that the events that were inserted using the OLD dependency from step 7 were still there
vincetran commented 11 hours ago

Oh also, validated that configuring the cloudwatch plugin to start syncing logs up to CloudWatch successfully uploaded the logs and I could see it in the console :)

codecov[bot] commented 11 hours ago

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 44.04%. Comparing base (7f874ed) to head (d7bff5f). Report is 21 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2919 +/- ## ========================================== + Coverage 44.01% 44.04% +0.02% ========================================== Files 926 932 +6 Lines 30485 30601 +116 Branches 4351 4524 +173 ========================================== + Hits 13419 13478 +59 - Misses 15601 15622 +21 - Partials 1465 1501 +36 ```

🚨 Try these New Features: