Open ataylorme opened 4 weeks ago
System: OS: macOS 14.6.1 CPU: (8) arm64 Apple M2 Memory: 140.08 MB / 16.00 GB Shell: /bin/zsh Binaries: Node: 20.11.0 - ~/.nvm/versions/node/v20.11.0/bin/node Yarn: undefined - undefined npm: 10.2.4 - ~/.nvm/versions/node/v20.11.0/bin/npm pnpm: undefined - undefined NPM Packages: @aws-amplify/auth-construct: 1.3.0 @aws-amplify/backend: 1.2.0 @aws-amplify/backend-auth: 1.1.3 @aws-amplify/backend-cli: 1.2.5 @aws-amplify/backend-data: 1.1.3 @aws-amplify/backend-deployer: 1.1.0 @aws-amplify/backend-function: 1.3.4 @aws-amplify/backend-output-schemas: 1.2.0 @aws-amplify/backend-output-storage: 1.1.1 @aws-amplify/backend-secret: 1.1.0 @aws-amplify/backend-storage: 1.1.2 @aws-amplify/cli-core: 1.1.2 @aws-amplify/client-config: 1.3.0 @aws-amplify/deployed-backend-client: 1.4.0 @aws-amplify/form-generator: 1.0.1 @aws-amplify/model-generator: 1.0.5 @aws-amplify/platform-core: 1.0.7 @aws-amplify/plugin-types: 1.2.1 @aws-amplify/sandbox: 1.2.0 @aws-amplify/schema-generator: 1.2.1 aws-amplify: 6.5.4 aws-cdk: 2.154.1 aws-cdk-lib: 2.154.1 typescript: 5.5.4 AWS environment variables: AWS_STS_REGIONAL_ENDPOINTS = regional AWS_NODEJS_CONNECTION_REUSE_ENABLED = 1 AWS_SDK_LOAD_CONFIG = 1 No CDK environment variables
Currently the FunctionProp type only allows for specific props.
FunctionProp
Allow all optional props for NodejsFunction, such as logRetention, to be passed to defineFunction
logRetention
defineFunction
NodejsFunction
@aws-amplify/backend
@ykethan I created #1971 to implement this feature. It would be great to get it reviewed or at least the test run allowed so I can fix things as needed
Environment information
Describe the feature
Currently the
FunctionProp
type only allows for specific props.Allow all optional props for NodejsFunction, such as
logRetention
, to be passed todefineFunction
Use case
NodejsFunction
todefineFunction
from@aws-amplify/backend
defineFunction
from@aws-amplify/backend