aws-amplify / amplify-backend

Home to all tools related to Amplify's code-first DX (Gen 2) for building fullstack apps on AWS
Apache License 2.0
166 stars 55 forks source link

update fallback for backend id resolvers if stack, app id, or branch are in args #2034

Closed rtpascual closed 1 week ago

rtpascual commented 1 week ago

Problem

Came from https://github.com/aws-amplify/amplify-backend/pull/2028#discussion_r1768862801.

If stack, app id, or branch are passed in as an argument for generate commands, there is no intention to run these commands against a sandbox.

Issue number, if available:

Changes

Only fallback to resolving sandbox backend identifier if stack, app id, and branch are not passed in as arguments to generate commands.

Corresponding docs PR, if applicable:

Validation

Updated unit test.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

changeset-bot[bot] commented 1 week ago

🦋 Changeset detected

Latest commit: 249206cc7eb07db147a3b6a6d3a7f5680553195b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------------ | ----- | | @aws-amplify/backend-cli | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR