Closed ShadowCat567 closed 4 days ago
Latest commit: 58f2e01716312bc2d8e32a0d2f949219dc037baf
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Problem
@aws-amplify/backend
sometimes does not properly inherit the right kind of version bump from its dependencies.Issue number, if available: https://github.com/aws-amplify/amplify-backend/issues/1693
Changes
check_changeset_completeness.ts
to be split into functionscheck_changeset_completeness.ts
that check whether backend should be inheriting a version bump and whether it is currently inheriting the right kind of version bump Corresponding docs PR, if applicable:Validation
ran manual tests using different version bumps for
backend
and its dependenciesTest 1:
backend: none
, dependencies have version bump ofminor
Test 2:
backend: minor
, dependencies areminor
ornone
Test 3:
backend: patch
, dependencies areminor
orpatch
Test 4:
backend: patch
, no dependency versionsTest 5:
backend: minor
, one dependency ismajor
Checklist
run-e2e
label set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.