aws-amplify / amplify-backend

Home to all tools related to Amplify's code-first DX (Gen 2) for building fullstack apps on AWS
Apache License 2.0
184 stars 62 forks source link

Update to `stop:npm-proxy` for Windows #2053

Closed ShadowCat567 closed 1 month ago

ShadowCat567 commented 1 month ago

Problem

npm:stop-proxy command was unable to be run without an error on Windows, so verdaccio process could not be killed. This stems from lsof command not existing on Windows.

Issue number, if available:

Changes

Corresponding docs PR, if applicable:

Validation

Checked that process running on verdaccio port is killed after stop:npm-proxy command is run

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: eb259406c874b2d4ecdd2dd46ac12c38f2a11751

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR