aws-amplify / amplify-backend

Home to all tools related to Amplify's code-first DX (Gen 2) for building fullstack apps on AWS
Apache License 2.0
184 stars 62 forks source link

Windows line endings in scripts tests #2059

Closed ShadowCat567 closed 1 month ago

ShadowCat567 commented 1 month ago

Problem

Windows line endings (\r\n) would cause tests in api_usage_generator.test.ts to fail because the expected output would differ from the actual output due to \r character. Issue number, if available:

Changes

\r characters are now replaced with empty strings in the actual output Corresponding docs PR, if applicable:

Validation

tests are now passing on Windows

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: d9492c561e3e9598d3506f2c2945f44d5c474dc3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR