aws-amplify / amplify-backend

Home to all tools related to Amplify's code-first DX (Gen 2) for building fullstack apps on AWS
Apache License 2.0
184 stars 62 forks source link

avoid client config generation race condition #2184

Closed rtpascual closed 2 weeks ago

rtpascual commented 2 weeks ago

Problem

There seems to be a race condition between client config generation and asserting post deployment, sometimes we see this error: Screenshot 2024-11-01 at 10 33 02 AM

Compared to a successful run: Screenshot 2024-11-01 at 10 41 28 AM

Issue number, if available:

Changes

Use existing waitForConfigUpdateAfterDeployment action to wait for amplify_outputs.json to be generated before interrupting sandbox and asserting post deployment.

Also following https://github.com/aws-amplify/amplify-backend/pull/2160, removed the rejectCleanupSandbox action since the prompt no longer exists.

Corresponding docs PR, if applicable:

Validation

E2E tests and canary test run https://github.com/aws-amplify/amplify-backend/actions/runs/11635102140.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 1ec2c610b679c8a867a95507d734982695928bd9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR