Closed sobolk closed 1 week ago
Latest commit: 2e6418c1dc418bc4e3e0f450dfae8353ff861312
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
The change is in the right direction.
I fear the new
advanced
e2e test will become a dumping ground to add unrelated concepts for testing. Ideally we should split this further and name them as specific as possible such that each test on average covers one customer use case.
@Amplifiyer That would be ideal. However, there are two constraints that are in the way (or will be at some point):
Given that. I think that the important aspect is to make sure (maybe find some abstractions?) that independent scenarios that are part of single project being deployed are not being coupled. (an example of that is using separate group of resources to test scheduled functions vs testing custom email sender, both use sqs queues, but their resources are separate from each other).
Problem
The
data-storage-auth-with-triggers-ts
got crowded with rather advanced use cases.This impacts:
Changes
Extract functions and auth scenarios that can be standalone project.
Out of scope
I was thinking about extracting entirety of storage and functions scenarios but I noticed that we also use
data-storage-auth-with-triggers-ts
project inbackend_outputs
test. Therefore I decided to go slower and extract only scenarios that wouldn't impact that coverage.Validation
PR checks.
before Overal runtime: 23m 26s
after Overal runtime: 14m 30s
Checklist
run-e2e
label set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.