aws-amplify / amplify-backend

Home to all tools related to Amplify's code-first DX (Gen 2) for building fullstack apps on AWS
Apache License 2.0
185 stars 62 forks source link

Add retry mechanism to create amplify e2e test #2220

Closed sobolk closed 1 week ago

sobolk commented 1 week ago

Problem

Handles image

Changes

  1. Generalize retry predicate from package manager test.
  2. Use it in create amplify test.
  3. Add connection error.

Validation

This PR checks.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

changeset-bot[bot] commented 1 week ago

🦋 Changeset detected

Latest commit: 2b482319706bee3ca51bed170a7351c489df615d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

sobolk commented 1 week ago

looks good, are customers hitting this too?

They are. But that's happening in package manager before our code is called or when we call package manager to install deps. we don't have control over that.