aws-amplify / amplify-backend

Home to all tools related to Amplify's code-first DX (Gen 2) for building fullstack apps on AWS
Apache License 2.0
185 stars 62 forks source link

set removal policy for resources to destroy in sandbox deployments #2242

Closed rtpascual closed 2 days ago

rtpascual commented 3 days ago

Problem

For sandbox, some resources are still retained even after running ampx sandbox delete.

Issue number, if available:

Changes

Set RemovalPolicy on all sandbox resources to DESTROY to guarantee all resources are destroyed when deleting a sandbox.

Corresponding docs PR, if applicable:

Validation

Unit tests. Local project with a stateful resource (OpenSearch) and ensure all resources are deleted after running ampx sandbox delete.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

changeset-bot[bot] commented 3 days ago

🦋 Changeset detected

Latest commit: 120704dc2818d59926d73b1159826dab1aa9a53a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------- | ----- | | @aws-amplify/backend | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR