aws-amplify / amplify-cli

The AWS Amplify CLI is a toolchain for simplifying serverless web and mobile development.
Apache License 2.0
2.81k stars 821 forks source link

prepend "Apple" to SIWA input prompts to align with other providers #11222

Open josefaidt opened 1 year ago

josefaidt commented 1 year ago

Is this feature request related to a new or existing Amplify category?

No response

Is this related to another service?

No response

Describe the feature you'd like to request

Other OAuth providers have prompts prepended with the provider name "Enter your Facebook...", "Enter your Google", however SIWA does not also have this prepended provider name.

 You've opted to allow users to authenticate via Facebook.  If you haven't already, you'll need to go to https://devel
opers.facebook.com and create an App ID. 

 Enter your Facebook App ID for your OAuth flow:  fakeappid
 Enter your Facebook App Secret for your OAuth flow:  fakeappsecret

 You've opted to allow users to authenticate via Google.  If you haven't already, you'll need to go to https://develop
ers.google.com/identity and create an App ID. 

 Enter your Google Web Client ID for your OAuth flow:  fakeclientid
 Enter your Google Web Client Secret for your OAuth flow:  fakeclientsecret

 You've opted to allow users to authenticate via Sign in with Apple. If you haven't already, you'll need to go to http
s://developer.apple.com/account/#/welcome and configure Sign in with Apple. 

 Enter your Services ID for your OAuth flow:  com.fake.com
 Enter your Team ID for your OAuth flow:  faketeamid
 Enter your Key ID for your OAuth flow:  fakekeyid
 Enter your Private Key for your OAuth flow: asdfahsdflkjashdflkjashdflkjahs

Describe the solution you'd like

 You've opted to allow users to authenticate via Facebook.  If you haven't already, you'll need to go to https://devel
opers.facebook.com and create an App ID. 

 Enter your Facebook App ID for your OAuth flow:  fakeappid
 Enter your Facebook App Secret for your OAuth flow:  fakeappsecret

 You've opted to allow users to authenticate via Google.  If you haven't already, you'll need to go to https://develop
ers.google.com/identity and create an App ID. 

 Enter your Google Web Client ID for your OAuth flow:  fakeclientid
 Enter your Google Web Client Secret for your OAuth flow:  fakeclientsecret

 You've opted to allow users to authenticate via Sign in with Apple. If you haven't already, you'll need to go to http
s://developer.apple.com/account/#/welcome and configure Sign in with Apple. 

 Enter your Apple Services ID for your OAuth flow:  com.fake.com
 Enter your Apple Team ID for your OAuth flow:  faketeamid
 Enter your Apple Key ID for your OAuth flow:  fakekeyid
 Enter your Apple Private Key for your OAuth flow: asdfahsdflkjashdflkjashdflkjahs

Describe alternatives you've considered

n/a

Additional context

No response

Is this something that you'd be interested in working on?

Would this feature include a breaking change?

evcodes commented 1 year ago

still working on this, just making a larger than expected to the change in the code.