Closed paddlefish closed 5 years ago
Thanks @paddlefish for letting us know. We've already updated the codebase for this and the PR is currently pending review. https://github.com/aws-amplify/amplify-cli/pull/1267
@UnleashedMind will you please clarify one point here.
After fix is merged, will updating amplify-cli
be enough for existing project (just push the codebase with updated cli version) to update the runtime Node? Or we need to manually update cloudformation templates for existing projects? Thanks.
I am hoping that whether with an automatic upgrade of a project from 6.10 to 8.10, or with the manual updating of the template, that any project upgrade will only effect the node version for the Lambda and not effect the Cognito User Pool or Federated Identity that might be attached to the auth service.
Can this also be confirmed? Thank you.
@yuyokk Thanks for bringing it up. We'll also add to our document about this. For existing project, if you plan to update anything related to lambda, such as resources from the Amplify CLI Function category, or custom resources backed by Lambda function (e.g. analytics, interactions, etc. ), then you will have to manually update the node version in the CloudFormation template.
@leantide Auth also uses custom resources backed by Lambda function. So this update shouldn't affect resources already created for the auth category. But if you need to update them (if you created auth before v1.6.x release), then you will need to manually update the node version in the Auth Cloudformation template.
We upgraded our default Cloudformation tempaltes to NodeJS 8.10 with the latest version of the CLI. Here's a quick migration guide out here if you're using an older version/template in your project - https://aws-amplify.github.io/docs/cli/lambda-node-version-update
This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.
Looking for a help forum? We recommend joining the Amplify Community Discord server *-help
channels for those types of questions.
Describe the bug AWS is deprecating Node 6.10 Within a few weeks it will no longer be possible to deploy lambdas using Node6.10. Amplify CLI Auth creates a Node6.10 Lambda.
Here's the message from AWS that arrived in my inbox because I used
amplify add auth
on my account:To Reproduce Steps to reproduce the behavior:
Expected behavior Nodejs8.10
Screenshots If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information): Darwin Kernel Version 18.5.0: Mon Mar 11 20:40:32 PDT 2019; root:xnu-4903.251.3~3/RELEASE_X86_64
Smartphone (please complete the following information): n/a
Additional context
The lambda is created by the cloud formation template packages/amplify-category-analytics/provider-utils/awscloudformation/cloudformation-templates/pinpoint-cloudformation-template.json
Note: There is also another template packages/amplify-category-interactions/provider-utils/awscloudformation/cloudformation-templates/lex-cloudformation-template.json.ejs but I don't use that so someone else can write up that bug.
Sample code
Here's a snippet of pinpoint-cloudformation-template.json
You can turn on the debug mode to provide more info for us by setting window.LOG_LEVEL = 'DEBUG'; in your app.