improve validation on `sign in with apple` private key - Githubissues

aws-amplify / amplify-cli

The AWS Amplify CLI is a toolchain for simplifying serverless web and mobile development.

Apache License 2.0

2.82k stars 821 forks source link

improve validation on `sign in with apple` private key #13065

Open ykethan opened 1 year ago

ykethan commented 1 year ago

How did you install the Amplify CLI?

No response

If applicable, what version of Node.js are you using?

No response

Amplify CLI Version

12.2.3

What operating system are you using?

mac

Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.

no

Describe the bug

It appears the validation on CLI allows just typing in the begin and end of the private key image (8)

Expected behavior

validate and throw appropriate message

Reproduction steps

add auth
select signin with apple
enter the begin and end without the hash key
observe no errors

Project Identifier

No response

Log output

``` # Put your logs below this line ```

Additional information

No response

Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

josefaidt commented 1 year ago

related https://github.com/aws-amplify/amplify-cli/issues/8097 marking as a feature request