fix: don't create symlinks after extracting zip - Githubissues

aws-amplify / amplify-cli

The AWS Amplify CLI is a toolchain for simplifying serverless web and mobile development.

Apache License 2.0

2.81k stars 819 forks source link

fix: don't create symlinks after extracting zip #13791

Closed Amplifiyer closed 4 months ago

Amplifiyer commented 4 months ago

Description of changes

fix: don't create symlinks after extracting zip

Issue #, if available

Description of how you validated changes

Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
[ ] Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Amplifiyer commented 4 months ago

couple comments but I don't think they are functional blockers. Should this PR be based off of hotfix instead of dev?

We only have https://github.com/aws-amplify/amplify-cli/commit/d583756cdb6d8012102a3a6e117e987e2e2da985 in the dev that is a functional change. I think we can use regular release for this.