search

aws-amplify / amplify-cli

The AWS Amplify CLI is a toolchain for simplifying serverless web and mobile development.
Apache License 2.0
2.81k stars 819 forks source link

fix(amplify-cli-core): use build script for overrides #13858

Open brianlenz opened 2 months ago

brianlenz commented 2 months ago

Updated the TypeScript compilation of overrides so that it doesn't require node_modules/.bin/tsc. Instead, it simply relies on the build script to execute tsc. This is more flexible and can support alternative setups w/ hoisting (e.g. via Yarn workspaces).

This is an override corollary fix to #11854, which is for custom resources.

Description of changes

Remove hard-coded dependency on node_modules/.bin/tsc for overrides to instead use the build script from package.json, which is more flexible.

Issue #11889

Description of how you validated changes

Ran yarn test and all pre-commit hooks without issue. Tested amplify build --debug and amplify push locally. The commands were failing on Amplify CLI 12.12.4, and it succeeds with these changes in place (via amplify-dev).

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

brianlenz commented 1 month ago

@josefaidt sorry to pester, but any chance this can get some attention? Would love to be able to stop using custom builds of the CLI! Thanks! 🙏