aws-amplify / amplify-cli

The AWS Amplify CLI is a toolchain for simplifying serverless web and mobile development.
Apache License 2.0
2.83k stars 822 forks source link

fix: remove node-ip dependency #13877

Closed jwilson-anonyome closed 3 months ago

jwilson-anonyome commented 3 months ago

Description of changes

Remove dependency on poorly maintained "ip" package, which has an open security advisory https://github.com/indutny/node-ip/issues/150

Implement an equivalent getLocalIpAddress() function that returns the first internal IP address. This is used by clients of the appsync-sumulator to connect to.

Issue #, if available

https://github.com/aws-amplify/amplify-cli/issues/13890

Description of how you validated changes

Ran yarn lerna run --scope @aws-amplify/amplify-appsync-simulator test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

0618 commented 3 months ago

Thank you for contributing!