aws-amplify / amplify-cli

The AWS Amplify CLI is a toolchain for simplifying serverless web and mobile development.
Apache License 2.0
2.8k stars 819 forks source link

Custom auth provider and custom auth domain got removed with an amplify auth update to change cognito triggers #6715

Open kylekirkby opened 3 years ago

kylekirkby commented 3 years ago

Is your feature request related to a problem? Please describe. So you want a custom domain for your auth resouce? Great You also want to add another Auth Provider, like you own SSO portal running Keycloak? Great!

But then you also want to enable/disable/change some Cognito Lambda triggers. You run amplify update auth and suddenly everything is gone again. :( No longer is your custom domain added or your custom OpenID provider!

Describe the solution you'd like The ability to not have everything get blow away when you want to update your Cognito Lambda triggers. Add a custom OpenID option for auth providers. Add a custom domain option for the auth resource.

Describe alternatives you've considered

Additional context https://github.com/aws-amplify/amplify-cli/issues/6701 https://github.com/aws-amplify/amplify-cli/issues/1880 https://github.com/aws-amplify/amplify-cli/pull/6499/files

akshbhu commented 3 years ago

@kylekirkby Marking this an an enhancement because auth in general does not support updates very well . Its similar to this issue : https://github.com/aws-amplify/amplify-cli/issues/6701. For now workarounds, alternatives you mentioned are the options which you can do to get unblocked.